Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes: Pressing 4 when not in "OpenStreetMap notes" mode give no visual information #5190

Closed
magol opened this issue Jul 28, 2018 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@magol
Copy link

magol commented Jul 28, 2018

If I don't have enabled the "OpenStreetMap notes" mode and use the keyboard shortcut 4, the 'Add note' mode is activated, but you don't get any visual information what is going on.

Normally when you go in to a add mode, the Point/Line/Area button is marked to indicate what you are doing. The same when you are in "OpenStreetMap notes" mode and adding a note. But if you have not enabled the "OpenStreetMap notes" mode and accidentally hit 4, you don't know what mode you are in.

Suggested solutions:

  • Don't allow 4 when "OpenStreetMap notes" are disabled
  • Automatic enable "OpenStreetMap notes" when hitting 4 (I prefer this)
@bhousel bhousel added the bug A bug - let's fix this! label Aug 1, 2018
@bhousel bhousel closed this as completed in 12f402c Aug 6, 2018
@bhousel
Copy link
Member

bhousel commented Aug 6, 2018

Thanks for reporting @magol .. I went with this: "Don't allow 4 when "OpenStreetMap notes" are disabled"

I chose this solution because it's probably easy for users to hit 4 without thinking about it, and if they don't know about the notes layer, they would be confused to have it enabled and put into Add Note mode. For now, we'll continue to make enabling the notes layer be a thing they need to purposely opt in to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants