Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for shop=sewing #5267

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Add preset for shop=sewing #5267

merged 1 commit into from
Sep 4, 2018

Conversation

kymckay
Copy link
Collaborator

@kymckay kymckay commented Aug 30, 2018

Fixes #5244

@vershwal
Copy link
Collaborator

Hey @SilentSpike. Looks good, but you need to run npm run build before pushing any code, this command will build your project and also notify if there is any error. In your case after adding data/presets/presets/shop/sewing.json if you run npm run build it will update the following four files :
data/presets.yaml
data/presets/presets.json
data/taginfo.json
dist/locales/en.json

I would suggest you to build the code and push the changes again.
Thanks!!

@kymckay
Copy link
Collaborator Author

kymckay commented Aug 31, 2018

Thanks, I've now amended my commit. Worth noting the build added some other lines to dist/locales/en.json which I manually removed since they're unrelated to this PR (looks like they're imagery related).

@vershwal
Copy link
Collaborator

Yeah! Looks good to me.

@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

Thanks @SilentSpike 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants