Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic seamark presets #5297

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

quincylvania
Copy link
Collaborator

Seamarks represent tens of thousands of OSM features. This PR adds presets for common seamarks that users may come across, with these design goals in mind:

  • Make common seamarks more legible when encountered in iD
  • Make common seamarks faster to map
  • Avoid confusion and mistagging opportunities

Several changes were made based off feedback from PR #5286:

  • Usage of the name Channel Buoy instead of Lateral Buoy for a more obvious meaning
  • Addition of Red Buoy and Green Buoy presets. These are easy to identify and imply their identity as lateral buoys without the user needing to know the details

All Changes:

  • Adds presets: Seamark (unsearchable generic), Channel Buoy, Green Buoy, Red Buoy, Channel Beacon, Danger Beacon, Mooring
  • Adds universal Seamark type field to Seamark preset
  • Adds Category, Colour, Shape, and System fields to buoy and Channel Beacon presets
  • Adds Shape field to Danger Beacon preset
  • Adds Category field to Mooring preset

As always, I'm totally open to feedback, changes, and further discussion.

Also closes #5285.

…y, Red Buoy, Channel Beacon, Danger Beacon, Mooring

Adds universal Seamark type field to Seamark preset
Adds Category, Colour, Shape, and System fields to buoy and Channel Beacon presets
Adds Shape field to Danger Beacon preset
Adds Category field to Mooring preset
@bhousel
Copy link
Member

bhousel commented Sep 8, 2018

Thanks @quincylvania 👍 looks good to me..

@bhousel bhousel merged commit c87eec7 into openstreetmap:master Sep 8, 2018
@quincylvania quincylvania deleted the basic-seamarks branch September 8, 2018 17:33
@NKAmapper
Copy link

@don-vip @Skippern

@Skippern
Copy link

Skippern commented Sep 9, 2018

Adding @malcolmh

@Skippern
Copy link

Skippern commented Sep 9, 2018

iD can recognise the areas of IALA A and IALA B and automatically add the correct IALA tags depending on area. Exact definition of the polygon limits of these regions are available, but a simplification is Americas, Korea, Japan, and Philippines in IALA B and the rest of the world in IALA A.

@quincylvania
Copy link
Collaborator Author

@Skippern Adding these tags automatically would indeed be useful. However, there is currently no way to tell iD to take geographic region into account when applying presets. There has been some talk around adding region-based preset logic, though not directly addressing this specific circumstance. See #4871 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create preset for seamark:type=buoy_lateral
4 participants