Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: traffic signs to new endpoint #5395

Closed
wants to merge 1 commit into from
Closed

fix: traffic signs to new endpoint #5395

wants to merge 1 commit into from

Conversation

cbeddow
Copy link
Contributor

@cbeddow cbeddow commented Oct 10, 2018

iD was using the old v3/objects API and needs to be v3/map_features with the parameter layers=trafficsigns set. Also changed v3/detections to v3/image_detections API although I think this is not used right now.

@bhousel
Copy link
Member

bhousel commented Oct 11, 2018

Thanks @cbeddow - I restored the newlines back from CRLF -> CR, and fixed the tests.

There is another issue with the api call which fetches the detections within the current image (this is to draw the boxes over the detected signs), so I'll leave #5374 open for now.

@bhousel bhousel mentioned this pull request Oct 11, 2018
Closed
@bhousel
Copy link
Member

bhousel commented Oct 11, 2018

This was actually merged - not sure why GitHub missed it

@bhousel bhousel closed this Oct 11, 2018
@bhousel bhousel mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeddow @bhousel