Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for To and From and add fields to all route presets. #5410

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Add fields for To and From and add fields to all route presets. #5410

merged 2 commits into from
Oct 24, 2018

Conversation

castriganoj
Copy link
Contributor

I took a stab at this as a first time iD contributor. Please review and let me know if anything if changes are needed.

Thanks for participating in Hacktoberfest.

Best,
Jim

#5408

Copy link
Contributor

@manfredbrandl manfredbrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the changes about Helsingborg and Stockholm municipality from dist/locales/en.json. I think this does not belong here.

@JamesKingdom
Copy link
Collaborator

@manfredbrandl The changes about Helsingborg and Stockholm don't need to be removed. it's just the imagery information updating when iD has been rebuilt.
You can see in other PR's such as #5397, that it's just left in.

data/presets/fields/to.json Outdated Show resolved Hide resolved
@bhousel
Copy link
Member

bhousel commented Oct 18, 2018

The changes about Helsingborg and Stockholm don't need to be removed. it's just the imagery information updating when iD has been rebuilt.

Agree - this is just different people having different versions of ELI, which we can't help. It all sorts itself out when I make a release.

Co-Authored-By: castriganoj <castriganoj@gmail.com>
@bhousel
Copy link
Member

bhousel commented Oct 24, 2018

Thanks @castriganoj 👍

@bhousel bhousel merged commit 8de0c8f into openstreetmap:master Oct 24, 2018
@castriganoj castriganoj deleted the AddToAndFromFieldsToRoutePresets#5408 branch October 25, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants