Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale bar breaks when using browser a11y settings to zoom #5437

Closed
jidanni opened this issue Oct 26, 2018 · 9 comments
Closed

Scale bar breaks when using browser a11y settings to zoom #5437

jidanni opened this issue Oct 26, 2018 · 9 comments
Labels
help wanted For intermediate contributors, requires investigation or knowledge of iD code

Comments

@jidanni
Copy link
Contributor

jidanni commented Oct 26, 2018

Scale bar missing in https://github.com/GNOME/epiphany browser.
#5435
Visible in chromium, missing in epiphany.
https://en.wikipedia.org/wiki/GNOME_Web
https://wiki.gnome.org/Apps/Web

@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 26, 2018

Cannot reproduce, scale bar is visible in epiphany here. Seems like some other issue on your machine.

@bhousel bhousel closed this as completed Oct 26, 2018
@bhousel
Copy link
Member

bhousel commented Oct 26, 2018

iD does have a scale bar. It does go away if your window really is too small.

I've included a screen shot, but you can also search the issue list for "scale bar" to find probably a dozen more screenshots and descriptions of this feature.

screenshot 2018-10-26 14 13 29

@jidanni
Copy link
Contributor Author

jidanni commented Oct 28, 2018

Ah ha!

Observe, at CTRL+0 zoom, scale bar present.
d1

Now at CTRL++ zoom,
d2

  1. Grey area where scale bar used to live taller
  2. "Help translate button" and "2.111" larger
  3. Plenty of room left for scale bar, but...

Poof! scale bar gone!

Please only make it go away when it finally bangs into something.

@jidanni jidanni changed the title Scale bar missing in GNOME/epiphany browser Scale bar needlessly removed with plenty of space remaining even at slightest zoom Oct 28, 2018
@jidanni
Copy link
Contributor Author

jidanni commented Oct 29, 2018

Wow you must be on a tiny screen - what is the resolution?

@tastrax Default resolution for IBM Thinkpad 50e, 1024x768 I recall... (but I'm on a different terminal today.)

@jidanni jidanni changed the title Scale bar needlessly removed with plenty of space remaining even at slightest zoom Scale bar should remain if space permits Oct 29, 2018
@jidanni
Copy link
Contributor Author

jidanni commented Oct 29, 2018

Now testing with Chromium at 1152x864. Scale bar remains until CTRL++++
zoom (150%) whereupon it disappears. But there is still plenty of room for it:
0

@tastrax
Copy link
Contributor

tastrax commented Oct 29, 2018

Why not just use the + key to zoom in? Why do you need everything magnified?

@jidanni
Copy link
Contributor Author

jidanni commented Oct 29, 2018

Why not just use the + key to zoom in? Why do you need everything magnified?

Usually because the fonts are too small, etc. (age 57).

@bhousel
Copy link
Member

bhousel commented Oct 29, 2018

I’ll look into it , but your browser may be trying to zoom the scale bar itself like any other graphic element . A zoomed-in scale bar will obviously be wrong and lie to you.

@bhousel bhousel reopened this Oct 29, 2018
@bhousel bhousel changed the title Scale bar should remain if space permits Scale bar breaks when using browser a11y settings to zoom Oct 29, 2018
@slhh
Copy link
Contributor

slhh commented Oct 29, 2018

The scale bar does also disappear in Edge and Firefox. It doesn't seem to become lying as long as it is visible.

@bhousel bhousel added the help wanted For intermediate contributors, requires investigation or knowledge of iD code label Nov 5, 2018
@bhousel bhousel closed this as completed in c25a212 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted For intermediate contributors, requires investigation or knowledge of iD code
Projects
None yet
Development

No branches or pull requests

5 participants