Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline text fields for long tag values #5444

Closed
quincylvania opened this issue Oct 28, 2018 · 6 comments
Closed

Multiline text fields for long tag values #5444

quincylvania opened this issue Oct 28, 2018 · 6 comments
Labels
usability An issue with ease-of-use or design

Comments

@quincylvania
Copy link
Collaborator

Spun off of #3447 (comment).

f6d68ba4-8189-11e6-8a71-50402a99754b

Currently, value text fields in the the raw tag editor are never taller than one line even if the text is very long. While #5443 will alleviate this issue by allowing the user to resize the sidebar and see more text, it would still be useful to allow the text to wrap onto multiple lines if needed.

@quincylvania quincylvania added the usability An issue with ease-of-use or design label Oct 28, 2018
@thefifthisa
Copy link
Contributor

I'd like to work on this!

@quincylvania
Copy link
Collaborator Author

@thefifthisa Go for it!

I tried working on this and it appeared to be somewhat more difficult than it looks, but maybe you can find a better solution!

@thefifthisa
Copy link
Contributor

@quincylvania Oh okay! Can I ask what approach you tried?

The comment mentioned that checking how long individual tag values are could get tedious, so I was thinking of having a set number of lines which the text can wrap onto before truncating with an ellipsis. What do you think?

@quincylvania
Copy link
Collaborator Author

That should be fine! The complicated part is that the existing implementation uses <input type="text"> which really only works for a single line. For multiline text entry, a <textfield> is needed, but that may not work with the combobox control.

@quincylvania
Copy link
Collaborator Author

We may not need this anymore since we have the text raw tag editor in #6302.

@bhousel
Copy link
Member

bhousel commented May 3, 2019

We may not need this anymore since we have the text raw tag editor in #6302.

Good point, we can close it..

@bhousel bhousel closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants