tag values with wiki page may be documented as bad

[matkoniecz]

fixes #5460

warning: this proposed code change is not tested

[matkoniecz]

Failed test is

includes unpopular values with a wiki page:

So test failure is a real problem.

Good news is that it will be easy to write a test for what I want to achieve here.

iD.serviceTaginfo
       #values
         includes unpopular values with a wiki page:

test is at

iD/test/spec/services/taginfo.js

Line 223 in 6ce2c5e

it('includes unpopular values with a wiki page', function() {

[matkoniecz]

I attempted to invert tests covering inverted behaviour.

[matkoniecz]

It is still failing with

  1) iD.serviceTaginfo
       #keys
         does not include unpopular keys with a wiki page:
     expected spy to have been called with arguments null, [{ title: "amenity", value: "amenity" }]
null
[{ title: "amenity", value: "amenity" }, { title: "amenityother", value: "amenityother" }] [{ title: "amenity", value: "amenity" }] 
  AssertionError@file:///home/mateusz/Desktop/tmp/iD/node_modules/chai/chai.js:9449:24
  assert@file:///home/mateusz/Desktop/tmp/iD/node_modules/chai/chai.js:239:31
  file:///home/mateusz/Desktop/tmp/iD/node_modules/sinon-chai/lib/sinon-chai.js:105:24
  methodWrapper@file:///home/mateusz/Desktop/tmp/iD/node_modules/chai/chai.js:7824:30
  file:///home/mateusz/Desktop/tmp/iD/test/spec/services/taginfo.js:99:53

I admit that I am not sure what this test is really reporting.

[matkoniecz]

Maybe tests fails because instead of [{ title: "amenity", value: "amenity" }] it got [{ title: "amenity", value: "amenity" }, { title: "amenityother", value: "amenityother" }] [{ title: "amenity", value: "amenity" }]?

[bhousel]

Maybe tests fails because instead of [{ title: "amenity", value: "amenity" }] it got [{ title: "amenity", value: "amenity" }, { title: "amenityother", value: "amenityother" }] [{ title: "amenity", value: "amenity" }]?

Yes probably this..

What I usually do is run iD locally, and then visit the test runner page http://localhost:8080/test in Chrome. It will run the tests in the browser and you can use the debugger to set breakpoints and figure out what's really going on 👍

[matkoniecz]

Note to self: it is described in https://github.com/openstreetmap/iD#building-id

Note to self: Open http://localhost:8080/ in a web browser is missing in https://github.com/openstreetmap/iD/blob/master/CONTRIBUTING.md#building--installing (EDIT: nope, it is two sections later )(and test runner page http://localhost:8080/test seems to be missing in both) - fixing that may be a good PR.

[bhousel]

I cleaned up the tests in a29af10

What I did was:

• remove the test for unpopular values with a wiki page
• restore the original test for unpopular keys with a wiki page

This matches what the code does now, and I think the intent of #5460

The code doesn't care about wiki pages for values anymore, so there is no need to test that behavior.
The code continues to give a boost to keys with wiki pages, so we do test that.

[matkoniecz]

Thanks for merging and fixing tests! Hopefully my next PR will go even better :)

[bhousel]

Thanks for merging and fixing tests! Hopefully my next PR will go even better :)

Thanks! This PR was great, no worries! 👍