Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preset for leisure=fishing #5469

Closed
bhousel opened this issue Nov 6, 2018 · 5 comments
Closed

Add preset for leisure=fishing #5469

bhousel opened this issue Nov 6, 2018 · 5 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@bhousel
Copy link
Member

bhousel commented Nov 6, 2018

I'm kind of surprised we don't have a preset for a "Fishing Spot" yet 🎣
https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dfishing
@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag labels Nov 6, 2018
@quincylvania
Copy link
Collaborator

Recommendations

  • Name: Fishing Spot
  • Geometry: point, area
  • Fields: name, access_simple, …
  • Terms: angler, …

@bhousel You beat me to it!

@bhousel
Copy link
Member Author

bhousel commented Nov 6, 2018

@bhousel You beat me to it!

Yeah I added this issue reel quick

@iandees
Copy link
Collaborator

iandees commented Nov 6, 2018 via email

@xmile1
Copy link
Contributor

xmile1 commented Nov 8, 2018 •
edited
Loading

I'm kind of surprised we don't have a preset for a "Fishing Spot" yet 🎣
https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dfishing

Hi, I can take this up, Its similar to this i did before i believe.

@bhousel
Copy link
Member Author

bhousel commented Nov 8, 2018

sounds good @xmile1 ! you can copy an existing file like data/presets/presets/leisure/bird_hide.json -> data/presets/presets/leisure/fishing.json and change the contents.

@bhousel bhousel added the wip Work in progress label Nov 8, 2018
@xmile1 xmile1 mentioned this issue Nov 8, 2018
Merged
@bhousel bhousel removed the wip Work in progress label Nov 9, 2018
@bhousel bhousel closed this as completed Nov 9, 2018
@bhousel bhousel mentioned this issue Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bhousel @iandees @quincylvania @xmile1