Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete button sometimes doesn't delete all the name suggestion tags #5573

Closed
bhousel opened this issue Dec 7, 2018 · 0 comments
Closed

Delete button sometimes doesn't delete all the name suggestion tags #5573

bhousel opened this issue Dec 7, 2018 · 0 comments

Comments

@bhousel
Copy link
Member

bhousel commented Dec 7, 2018

If you start off with a normal preset, and then change it to a suggestion preset by using the name field, and then try to delete the suggestion tags, sometimes iD will not delete them:

no delete tags

Root cause is because d3 has bound the initial field to the delete button, which thinks only name tag needs to be removed. Then later the field implementation has manipulated the field.keys list to include the full list of tags to remove. The fix is to make sure that the updated field is bound to the buttons in the update selection by using select() instead of selectAll.

(this is a common D3 gotcha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant