Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the initial inspector of the sidebar upon feature selection #5632

Conversation

quincylvania
Copy link
Collaborator

Old behavior: The preset list is shown when selecting a feature without tags (except area=yes) and that is not member of a relation. Otherwise show the editor.

New behavior: The preset list is shown when selecting a new feature or a vertex without tags. Otherwise show the editor.

@quincylvania quincylvania self-assigned this Dec 19, 2018
@bhousel
Copy link
Member

bhousel commented Dec 19, 2018

Sounds good to me!
Also nice to rename isUsed() to something more descriptive.

@quincylvania quincylvania merged commit 90e3cd8 into openstreetmap:master Dec 19, 2018
@quincylvania quincylvania deleted the sidebar-behavior-on-feature-selection branch December 19, 2018 23:07
@slhh
Copy link
Contributor

slhh commented Dec 20, 2018

@quincylvania I didn't like the old behavior in case of vertexes, but the new behavior makes it worse. E.g. it breaks the easy editing of turn restrictions.

I would show the preset list when assigning a preset is really required, and show the editor otherwise.
E.g.
New feature -> show the preset list
Existing feature without tags and relations (doesn't make sense without assigning a preset)-> show the preset list
vertex (assigning a preset is not mandatory) -> show the editor

This would make a shown preset list to be an indicator that the preset needs to be assigned. Currently it is not, because it neeeds to be ignored for vertexes in most cases.

@quincylvania
Copy link
Collaborator Author

@slhh Thanks for your feedback! Good point about the turn restriction editor. In 97c2361 I changed it back to showing the editor by default for intersection vertices.

Even though a vertex doesn't "need' tags, I think initially showing the preset list serves the primary use case of wanting to upgrade an untagged vertex to a specific preset.

The new behavior of initially showing the editor when selecting preexisting non-vertex features was changed in anticipation of upcoming validation UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants