-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of background imagery names and descriptions translation do not overwrite #5737
Comments
These look like the translations are all available on http://preview.ideditor.com/master - is this right? The dev mirror is updated frequently, whereas the iD on openstreetmap.org is only updated when we make a new release of iD. |
Yes, translations are already done on transifex and I'm checking on http://preview.ideditor.com/master . |
Ah ok, I just checked. I think this is probably because the imagery identifiers have There is a workaround in the code (search for |
Thanks for reporting @higa4 - I just pushed a fix.. Can you check this again in preview later today? |
I just checked and it looks fine. Thanks a lot! |
There are four background layer on editor-layer-index project's geojson in asia/jp.
https://github.com/osmlab/editor-layer-index/tree/gh-pages/sources/asia/jp
I set "i18n": true for these and traslated all of these names and descriptions on transifex which are expected to be shown on the "Background" panel of iD.
But only 1/4 is correctly overwritten by translated text and other 3/4 are not. (red square below)
correctly overwritten:
https://github.com/osmlab/editor-layer-index/edit/gh-pages/sources/asia/jp/JapanGSIKiban2500.geojson
not overwritten:
https://github.com/osmlab/editor-layer-index/edit/gh-pages/sources/asia/jp/JapanGSIStandardMap.geojson
https://github.com/osmlab/editor-layer-index/edit/gh-pages/sources/asia/jp/JapanGSIairphotoImagery.geojson
https://github.com/osmlab/editor-layer-index/edit/gh-pages/sources/asia/jp/JapanGSIorthoImagery.geojson
The text was updated successfully, but these errors were encountered: