Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Man_made Color representation #5759

Closed
jjiglesiasg opened this issue Jan 25, 2019 · 8 comments
Closed

Man_made Color representation #5759

jjiglesiasg opened this issue Jan 25, 2019 · 8 comments
Labels
usability An issue with ease-of-use or design
Milestone

Comments

@jjiglesiasg
Copy link

Today I realize that the breakwaters are now shown in blue and dotted from the previous white color; as been a man made structure my logic says that should be depicted with a different color that adjacent features like water, so keeping a different colors made sense, like wise for Dams and Weirs that are already blue two elements of different nature however related needs to be easilly spotted.
Could these be fixed? has been discussed somewhere?
Thanks

@bhousel bhousel added the usability An issue with ease-of-use or design label Jan 25, 2019
@quincylvania
Copy link
Collaborator

@jjiglesiasg The change was made in #5606 (cc: @RudyTheDev). There wasn't any discussion at the time—I'd like to hear what other people think!

@jjiglesiasg
Copy link
Author

I fully understand to depict water bodies with blue (as in regular printed maps) but man_made elements related with water or containing water do not make sense to me, and sometines are hard to be spooted for editing like dykes and breakwaters, or Dams and Weirs. I like the fill patern for water but not blue color for elements connecting with water.

@RudyTheDev
Copy link
Contributor

What color would work better? I wanted to not use white, because it would look like barriers, fences and such.

@jjiglesiasg
Copy link
Author

jjiglesiasg commented Jan 25, 2019

Hi, I do prefer to use like a brown color that could reassemble in some way concrete or stones, that is normally the material used for this kind of structures

@jjiglesiasg
Copy link
Author

If that could also be applied to Dams and Weirs I will be more than happy...

@RudyTheDev
Copy link
Contributor

I think waterway dam and weir are just default waterway rendering. I don't think weirs even have a preset. I guess they can get custom styles as well.

@bhousel bhousel closed this as completed in f79d3d1 Feb 1, 2019
@bhousel
Copy link
Member

bhousel commented Feb 1, 2019

I changed the color to use the same dark grey that we use for rocky things (like quarries).

screenshot 2019-02-01 14 35 07

@bhousel
Copy link
Member

bhousel commented Feb 1, 2019

I don't think weirs even have a preset. I guess they can get custom styles as well.

Oh btw, there is a weir preset, but they are defined only for vertices and lines, not areas.
The dam preset is allowed on all geometry types.

This is following the guidance on the OSM wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants