Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure comboboxes can work even if accept or cancel not fired #5825

Closed
bhousel opened this issue Jan 28, 2019 · 0 comments
Closed

Make sure comboboxes can work even if accept or cancel not fired #5825

bhousel opened this issue Jan 28, 2019 · 0 comments
Labels
bug A bug - let's fix this!
Milestone

Comments

@bhousel
Copy link
Member

bhousel commented Jan 28, 2019

It's possible to skip the accept or cancel event when using a combobox if the user selects a value with the arrow keys, but then clicks off the combo and blurs the field.

Most of the time, it's no big deal - but in some situations we have code that really expects to validate the combobox and replace its value:

blur field

d0021f7 fixes this issue for the brand suggestion preset combo
49442af fixes this issue for the raw member editor relation combo

@bhousel bhousel added the bug A bug - let's fix this! label Jan 28, 2019
@bhousel bhousel closed this as completed Jan 28, 2019
@bhousel bhousel added this to the 2.13.1 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

1 participant