Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for Golf Paths / Cartpaths #5859

Closed
chadrockey opened this issue Feb 5, 2019 · 5 comments
Closed

Add preset for Golf Paths / Cartpaths #5859

chadrockey opened this issue Feb 5, 2019 · 5 comments
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@chadrockey
Copy link
Contributor

I'm looking to extend similar to this:
https://github.com/openstreetmap/iD/blob/6ce2c5ea46b6bb89f8a3a3dd9d5794a920bbf610/data/presets/categories/golf.json

For lines types to bundle Golf->Hole with Golf->path (intended only for foot traffic) and Golf->cartpath (available for golfcarts).

These presets should create something like: highway=path and golf_cart=designated

My main question is, in order to add a value to the tag key "golf", such as "golf":"path" or "golf":"cartpath" is this mostly communal and metadata driven or is there a formal review process?

Once I find out how much formality is needed, I'll create the relevant json files for the presets and make a PR.

Originating discussion:
gravitystorm/openstreetmap-carto#3650

@bhousel
Copy link
Member

bhousel commented Feb 5, 2019

This is all I could find about them on the OSM wiki:
https://wiki.openstreetmap.org/wiki/Key:golf_cart

What you suggested for highway=path+golf_cart=designated seems good.

My main question is, in order to add a value to the tag key "golf", such as "golf":"path" or "golf":"cartpath" is this mostly communal and metadata driven or is there a formal review process?

Communal and metadata-driven. It is already used almost 10k times and it's a real thing that I'm sure people want to map, so adding a preset to iD is no problem.

@bhousel bhousel added new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag labels Feb 5, 2019
@chadrockey
Copy link
Contributor Author

Nice! Both are in use!
https://taginfo.openstreetmap.org/keys/golf#values

I'll get started on this immediately.

@BjornRasmussen
Copy link
Contributor

What you suggested for highway=path+golf_cart=designated seems good.

I don't care which tags are chosen for this preset, but I have found that most golf cart paths are tagged as highway=track in osm, and not highway=path.

@bhousel
Copy link
Member

bhousel commented Feb 6, 2019

I don't care which tags are chosen for this preset, but I have found that most golf cart paths are tagged as highway=track in osm, and not highway=path.

per #5862 (comment)
We're going to use new golf=* tags because many of these paths don't connect to the main routing graph, and we don't want the disconnected golf paths to be flagged as routing errors.

@bhousel
Copy link
Member

bhousel commented Feb 7, 2019

Done in #5862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants