Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalizing first letter of error message cause disjoining first Persian letter #5877

Closed
iriman opened this issue Feb 9, 2019 · 1 comment
Labels
localization Adapting iD across languages, regions, and cultures
Milestone

Comments

@iriman
Copy link
Contributor

iriman commented Feb 9, 2019

untitled

This is caused by

iD/css/80_app.css

Lines 2618 to 2620 in 6ff381c

.error-details-description-text::first-letter {
text-transform: capitalize;
}

A workaround is to add this rule

[dir="rtl"] .error-details-description-text::first-letter {
    text-transform: none;
}

But i'm not sure if all RTL languages don't have capital letters!

@bhousel bhousel added the localization Adapting iD across languages, regions, and cultures label Feb 9, 2019
@bhousel bhousel closed this as completed in 48d001d Feb 9, 2019
@bhousel
Copy link
Member

bhousel commented Feb 9, 2019

Thanks @iriman - I added the rule. We knew this was kind of a hacky rule to begin with, so we might need to find a better way to localize strings like these.

For anyone curious - it's about localizing messages like "This highway is missing a maxspeed tag". We split out the "this highway" part into a separate translatable string so that we can replace it with the actual name of the highway when/if iD knows it. We don't know for sure whether the "this highway" part will be at the beginning of the string, so we use a CSS rule to capitalize the first letter of the message.

This relates to #5679 .. cc @1ec5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

2 participants