Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check crossing features once #5923

Closed
quincylvania opened this issue Feb 21, 2019 · 1 comment
Closed

Only check crossing features once #5923

quincylvania opened this issue Feb 21, 2019 · 1 comment
Assignees
@quincylvania
Labels
performance Optimizing for speed and efficiency validation An issue with the validation or Q/A code
Milestone
2.14.2

Comments

@quincylvania
Copy link
Collaborator

quincylvania commented Feb 21, 2019 •
edited
Loading

Currently we run the crossing ways validation test twice if two features cross and you select one then the other. We should cache the results to improve performance.
@quincylvania quincylvania added validation An issue with the validation or Q/A code performance Optimizing for speed and efficiency labels Feb 21, 2019
@quincylvania
Copy link
Collaborator Author

Done in 51972ea.

@quincylvania quincylvania added this to the 2.14.2 milestone Feb 21, 2019
@quincylvania quincylvania self-assigned this Feb 21, 2019
@quincylvania quincylvania mentioned this issue Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
performance Optimizing for speed and efficiency validation An issue with the validation or Q/A code
Projects
None yet
Milestone
2.14.2
Development

No branches or pull requests
1 participant
@quincylvania