Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuisine: wrong separator and odd underscore with multiple values #6013

Closed
scaidermern opened this issue Mar 5, 2019 · 2 comments
Closed
Assignees
Labels
bug A bug - let's fix this! field An issue with a field in the user interface
Milestone

Comments

@scaidermern
Copy link
Contributor

iD seems to create odd cuisine tags if multiple values are present. It uses a comma instead of semicolon to separate multiple values and it starts subsequent values with a underscore.

Examples:

  • node 4172949589, cuisine=pizza,_italian_pizza,_pasta,_calzone,_lasagna,_vegan_pizza,_coffee, iD 2.1.0
  • node 307535899, cuisine=italian,_pizza,_pasta, iD 2.0.0
  • node 1329447976, cuisine=regional,_pizza,_pasta,_burger, iD 1.9.2

They are all over the place.

Unsure how to reproduce this error and if it is still present. However I couldn't find a related changelog entry or similar issue. Maybe this is a result of a free-form entry and a special rule to replace spaces in the value field with underscores?

@scaidermern
Copy link
Contributor Author

Oh, easy to reproduce. Try adding a cuisine value and instead of typing a single word type something like foo, bar which then gets replaced to foo,_bar.

I guess iD should prevent users from adding spaces and commas to a single cuisine value. Is it possible to implement such a syntax check?

@quincylvania
Copy link
Collaborator

@scaidermern Thanks for finding this! iD should automatically split to a new value when the user types a comma or semicolon in a multiCombo or semiCombo field.

@quincylvania quincylvania added the field An issue with a field in the user interface label Mar 5, 2019
@bhousel bhousel added the bug A bug - let's fix this! label Mar 5, 2019
@bhousel bhousel self-assigned this Mar 5, 2019
@bhousel bhousel closed this as completed in 166a500 Mar 5, 2019
@quincylvania quincylvania added this to the Next Release milestone Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! field An issue with a field in the user interface
Projects
None yet
Development

No branches or pull requests

3 participants