iD is corrupted after drawing an area that shares two nodes with an existing way

[1ec5]

iD is left in an inconsistent state, unable to save changes, after drawing a new area that shares a new node with an existing way and an existing node with that same way.

Steps to reproduce:

1. Zoom in to an area with roads (example).
2. Click Area to begin drawing a new area.
3. Click somewhere to create a new standalone node to serve as the area’s first vertex.
4. Click somewhere along an existing road (example) to create a new node that is shared between the new area and the road.
5. Click an existing node shared between that road and another road (example). (The issue doesn’t reproduce if you click an existing node that isn’t shared with another way.)

The area disappears with some visual artifacts, and the following error appears in the console:

[Error] Error: entity n619696893 not found
	entity (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:139:29047)
	childNodes (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:139:29743)
	(hàm ẩn danh) (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:157:16419)
	transient (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:139:29180)
	asGeoJSON (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:157:16368)
	c (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:10:907)
	filter
	e (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:11:1389)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	P (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:22:27065)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	s (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:22:20745)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	(hàm ẩn danh) (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:4745)
	selection_each (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:13497)
	render (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:4483)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	(hàm ẩn danh) (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:6051)
	selection_each (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:13497)
	c (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:6021)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	n (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:7707)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	n (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:14:28250)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	a (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:7073)
	selection_call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:12977)
	u (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:13240)
	e (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:23:11014)
	call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:27:1305)
	s (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:24:29473)
	pop (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:24:30688)
	(hàm ẩn danh) (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:25:17746)
	addNode (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:14:17694)
	addNode (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:13:23417)
	call (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:27:1305)
	l (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:8:23884)
	(hàm ẩn danh) (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:8:23606)
	(hàm ẩn danh) (id-6ab30e1034096334126217748050d0c321840827957e625add000f950125df1a.js:1:18621)

I have no idea where this node ID comes from, but it isn’t the node ID that you’ve just connected to.

At this point, if you place a new vertex that’s shared with the same road, the area still doesn’t show up but the road starts moving with the mouse cursor. All the while, more “entity not found” errors appear in the console. If you drag the map, sometimes only the background pans and the features are all stuck in place. If you save, the OSM API will return an HTTP 400 error with a message like Placeholder node not found for reference -1194 in way -196.

Reproduces consistently in iD v2.14.3 in both Firefox and Safari 12.0.3.

[1ec5]

This issue doesn’t seem to reproduce in master as of b5c2918. Not sure what might’ve fixed it.

[bhousel]

This is probably #5996

[quincylvania]

Closing this since it seems fixed.