Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag sources with incompatible licenses (e.g. Google Maps) #6135

Closed
quincylvania opened this issue Apr 2, 2019 · 0 comments
Closed

Flag sources with incompatible licenses (e.g. Google Maps) #6135

quincylvania opened this issue Apr 2, 2019 · 0 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@quincylvania
Copy link
Collaborator

quincylvania commented Apr 2, 2019

We currently flag changeset comments that mention Google:

Screen Shot 2019-04-02 at 7 41 02 AM

We should create an "Incompatible Data Source" validation warning that similarly flags source tags with such text on features.

Edit: This comment previously mentioned turning the changeset warning into a native validation issue. This would involve validating the actual changeset, which the validator isn't set up to do right now. We could consider this later in a separate issue if we really want to.

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Apr 2, 2019
@quincylvania quincylvania self-assigned this Apr 4, 2019
@quincylvania quincylvania added this to the 2.15.0 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

1 participant