Leave way as closed when disconnecting #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguthrie100
changed the title
jguthrie100
changed the title
|
@jguthrie100 Thanks so much! This is the way I should have solved it to begin with 🙈 |
|
We live and learn! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the fix in #6149 and makes it so that when a closed way is selected as well as the node to disconnect, the closed way gets disconnected from anything it is connected to, but remains closed.
I think this stay truer to the existing functionality where when a way is selected, the way is disconnected independently and every other connection remains as it was. Chances are that the user just wants to disconnect the closed way from the junction node, rather than opening up the way as well (which they can just do after if that was actually their intention)
If they do want to disconnect everything at the junction node, they can just right click the node without selecting any connected ways, and everything will be disconnected as usual.
I've also added a fix so that the option to disconnect doesn't even appear unless all selected ways are connected to the selected node, to save confusion on what actually will be disconnected, which is closer to how it was before #6149 was fixed.