Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Everything looks fine" message when filters are on #6224

Closed
quincylvania opened this issue Apr 23, 2019 · 4 comments
Closed

Improve "Everything looks fine" message when filters are on #6224

quincylvania opened this issue Apr 23, 2019 · 4 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@quincylvania
Copy link
Collaborator

Since we're validating everything in the background anyway, we could change this message to be more descriptive when filters are on.

Screen Shot 2019-04-23 at 9 53 02 AM

Something like:

Your edits in view look fine
17 issues detected elsewhere

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Apr 23, 2019
@bhousel
Copy link
Member

bhousel commented Apr 23, 2019

Oh yeah, I like this 👍
It also encourages people to play with the buttons.

Our not-so-subtle goal is to get people who are interested in validation to get hooked on it and spend hours making the map better.

@BjornRasmussen
Copy link
Contributor

17 issues detected elsewhere

Please no! I don't think that iD should be using all that processing power in the background if the contributer hasn't activated the validation for all objects.

@quincylvania
Copy link
Collaborator Author

@BjornRasmussen Have you edited on master in the past few days? iD is already validating everything in the background, even when set to My Edits 😆

@quincylvania quincylvania self-assigned this Apr 30, 2019
@quincylvania
Copy link
Collaborator Author

I did this along with #6242!

ignore issues demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants