Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add castle-related presets #6321

Merged
merged 1 commit into from
May 5, 2019

Conversation

westnordost
Copy link
Contributor

@westnordost westnordost commented May 5, 2019

  • man_made=cross, documented since 2011, used 4600+ times. This is a "cross of no religious or historic importance", so, usually a summit cross.
  • water=moat, documented since 2013, used 400+ times
  • historic=city_gate, documented since 2010, used 3000+ times
  • barrier=sally_port, documented since 2012/2016, used 4000+ times, approved. A side gate or postern in castles, e.g. for sorties.
  • historic=fort, documented since 2012/2016, used 3500 times
  • castle_type=fortress, documented since 2014 in German wiki and in English wiki since 2015, used 1400+ times. Heavily fortified castle for military use.
  • castle_type=palace, documented since 2014 in German wiki and in English wiki since 2015, used 1300+ times. A royal residence.
    There is also historic=palace, but it is used only 380+ times and was never documented.
  • castle_type=stately, documented since 2014 in German wiki only, translated to English wiki in 2017, used 4000 times. A residence of the nobility.
  • historic=manor, documented since 2011, used 5000+ times. Or mansion. A residence on an estate.
    There is also castle_type=manor, but it is used much less often (2300 times) and was documented later (2015). There is no discussion in the wiki whether historic=manor should be replaced by that castle_type=manor tagging.

How exactly some of the castle types presented here differ from another, for example manor vs stately, is I think not so important because in the end, what counts is the denomination used on the plaques / tourist guides / info booklets / wikipedia article. So, the mapper mapping with iD will likely input the denomination on this info material there and expect to get the correct preset for that.

By the way, "castle" may be used rather as a generic term for most of the above, that is why I did not add the castle_type=defensive - this would be the typical medieval castle.

@bhousel
Copy link
Member

bhousel commented May 5, 2019

Seems fine, thanks @westnordost 👍
Remember to try to use Title Case for the preset names.

@bhousel bhousel merged commit 0647ef9 into openstreetmap:master May 5, 2019
@westnordost
Copy link
Contributor Author

Oh right, I forgot it with the summit cross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants