Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter building:part and indoor #6352

Merged
merged 1 commit into from
May 22, 2019
Merged

Add filter building:part and indoor #6352

merged 1 commit into from
May 22, 2019

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented May 12, 2019

  • Extract the building:part from the building filter into it's own filter
  • Add indoor filtering
  • Update api doc

@tordans
Add filter building:part and indoor
35a2301 
- Extract the building:part from the building filter into it's own filter
- Add indoor filtering
- Update api doc
@tordans
Copy link
Collaborator Author

tordans commented May 12, 2019

@bhousel are you open to this topic and PR? I was just curious and looked into it for fun …

Also: Is this close to what needs doing? I am not sure if it is really just those few lines.

@quincylvania
Copy link
Collaborator

I haven't thought about it too much but I imagine these filters would be useful.

@quincylvania quincylvania added api An issue with the iD API / URL parameters usability An issue with ease-of-use or design labels May 13, 2019
@bhousel
Copy link
Member

bhousel commented May 13, 2019

Yes @tordans I think this looks ok 👍
I'd test these around places that have lots of building parts or indoor features mapped, to make sure they are catching everything you mean for them to (I'm not super familiar with the tags used for these things).

@quincylvania
Copy link
Collaborator

Pretty much everything indoors will have an indoor tag except for some highway=corridor. iD should probably recommend adding indoor=yes or indoor=corridor to those.

@quincylvania quincylvania marked this pull request as ready for review May 22, 2019 13:47
@quincylvania quincylvania merged commit 76b98f1 into openstreetmap:master May 22, 2019
@quincylvania quincylvania added this to the 2.15.1 milestone May 22, 2019
quincylvania added a commit that referenced this pull request May 22, 2019
@quincylvania
Update label and tooltips for indoor features and building parts (re: #…
96c0dbd 
…6352)
quincylvania added a commit that referenced this pull request May 22, 2019
@quincylvania
Hide indoor areas and building part areas when those features types a…
30b0190 
…re disabled (re: #6352)
@bhousel bhousel mentioned this pull request May 25, 2019
Merged
@tordans tordans deleted the filder-for-building-part-and-indoor branch July 20, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api An issue with the iD API / URL parameters usability An issue with ease-of-use or design
Projects
None yet
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tordans @quincylvania @bhousel