Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone numbers should be valid on businesses inside converted houses #6404

Closed
1ec5 opened this issue May 21, 2019 · 3 comments
Closed

Phone numbers should be valid on businesses inside converted houses #6404

1ec5 opened this issue May 21, 2019 · 3 comments
Assignees
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Milestone

Comments

@1ec5
Copy link
Collaborator

1ec5 commented May 21, 2019

A house that has been converted to a law office would be tagged building=house office=lawyer and would ideally be tagged with a phone number. But the validator flags the phone number as being a potential privacy violation:

personal

Per #5850 (comment), there is logic to exempt features with certain keys. Any business-specific key like office, brand, or website should be added to that heuristic. (Regarding website, self-hosted personal homepages are less common these days, so I figure it’s more likely to indicate the presence of a business.)

@1ec5 1ec5 added bug A bug - let's fix this! validation An issue with the validation or Q/A code labels May 21, 2019
@bhousel
Copy link
Member

bhousel commented May 21, 2019

Oh yeah, I've seen this a few times too. Usually I end up just changing the building type to - not one of these:

// assume that some buildings are private
var privateBuildingValues = {
detached: true,
farm: true,
house: true,
residential: true,
semidetached_house: true,
static_caravan: true
};

@quincylvania
Copy link
Collaborator

quincylvania commented May 22, 2019

iD won't flag residential buildings that also have one of these tags, so we can just add office to this list.

// but they might be public if they have one of these other tags
var publicKeys = {
amenity: true,
craft: true,
historic: true,
leisure: true,
shop: true,
tourism: true
};

@quincylvania quincylvania self-assigned this May 22, 2019
@quincylvania quincylvania added this to the 2.15.1 milestone May 22, 2019
@1ec5
Copy link
Collaborator Author

1ec5 commented May 22, 2019

Usually I end up just changing the building type to - not one of these

building=house is correct tagging – it remains architecturally a house – though building:use could be set to something else like commercial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants