Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upgrade to brands with matching country code #6448

Closed
1ec5 opened this issue May 28, 2019 · 1 comment
Closed

Only upgrade to brands with matching country code #6448

1ec5 opened this issue May 28, 2019 · 1 comment
Labels
bug A bug - let's fix this! preset An issue with an OpenStreetMap preset or tag

Comments

@1ec5
Copy link
Collaborator

1ec5 commented May 28, 2019

iD flags a POI as outdated and in need of upgrade even when it matches a brand that’s limited to a different country.

This pizzeria is tagged amenity=restaurant cuisine=pizza name=Cosmo with no brand tags. It’s located in the United States, but iD recommends “upgrading” it to a buffet chain named Cosmo that, according to osmlab/name-suggestion-index@d056824, only exists in Ireland and the UK. As far as I can tell, there’s no relation to the British chain.

cosmo

In this case, upgrading only added brand tags, but I could imagine another case where it changes the cuisine tag to something incorrect too.

@1ec5 1ec5 added bug A bug - let's fix this! preset An issue with an OpenStreetMap preset or tag labels May 28, 2019
@bhousel
Copy link
Member

bhousel commented Jun 11, 2019

moved to #6513

@bhousel bhousel closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants