Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Direction" to "Direction Affected" for direction fields on vertexes. #6469

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Change "Direction" to "Direction Affected" for direction fields on vertexes. #6469

merged 2 commits into from
Jun 3, 2019

Conversation

BjornRasmussen
Copy link
Contributor

The "Direction" field in vertexes in iD such as stop signs or traffic signals is quite unclear currently, since "Direction" could either mean "Direction of traffic affected" or "Direction that the sign/signal faces". I was confused about this when I first started mapping, so decided to just not add that information. Many people have asked on places like the osmus slack about this as well.
This pull request changes "Direction" to "Direction affected" to make this easier for new mappers to understand without checking wiki pages.

One question: the direction_vertex field is, as far as I know, only used in situations where there is a "Direction affected", so let me know if changing the label of that particular field will cause any issues.

…vertexes like traffic signals and stop signs.
@BjornRasmussen
Copy link
Contributor Author

BjornRasmussen commented Jun 2, 2019

All checks have failed

Hmm... Is there code that relies on the label being a certain value? I can't think of any way this change could have broken anything.

@quincylvania
Copy link
Collaborator

This seems like a good idea! A few implementation changes first:

  • We use Title Case for preset and field names, could you use "Direction Affected"?
  • Everything under dist is derived data and will be overwritten if edited. You'll need to change the name in the data/presets/fields/direction_vertex.json file and then run npm run build (or we can do that for you)

Feel free to ping me on Slack if you have questions!

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Jun 2, 2019
@BjornRasmussen
Copy link
Contributor Author

Ok, I've edited the correct files now and ran npm run build.
I tested it, and everything looks good now!
image

@BjornRasmussen BjornRasmussen changed the title Change "Direction" to "Direction affected" for some fields. Change "Direction" to "Direction Affected" for direction fields on vertexes. Jun 3, 2019
@quincylvania quincylvania merged commit 514e59a into openstreetmap:master Jun 3, 2019
quincylvania added a commit that referenced this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants