Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning for wifi=yes #6524

Closed
1ec5 opened this issue Jun 12, 2019 · 1 comment
Closed

Add deprecation warning for wifi=yes #6524

1ec5 opened this issue Jun 12, 2019 · 1 comment
Assignees
@quincylvania
Labels
validation An issue with the validation or Q/A code
Milestone
2.15.2

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jun 12, 2019 •
edited
Loading

It looks like iD’s Internet Access field adds internet_access=wlan when set to “Wi-Fi”. So even though the wiki page for wifi equivocates, a deprecation warning for wifi would promote internal consistency within iD:

  • wifi=yes → internet_access=wlan (combined with any existing value of internet_access)
  • wifi=free → internet_access=wlan internet_access:fee=no
  • wifi=no → ? (this doesn’t necessarily mean there’s no wired Internet access)
@1ec5 1ec5 added the validation An issue with the validation or Q/A code label Jun 12, 2019
@matkoniecz
Copy link
Contributor

Note that in case that internet_access already has some value it should not be overwritten.

@quincylvania quincylvania self-assigned this Jun 12, 2019
@quincylvania quincylvania added this to the 2.15.2 milestone Jun 12, 2019
@bhousel bhousel mentioned this issue Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
validation An issue with the validation or Q/A code
Projects
None yet
Milestone
2.15.2
Development

No branches or pull requests
3 participants
@matkoniecz @1ec5 @quincylvania