Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't flag very close points on different layers/levels #6612

Closed
quincylvania opened this issue Jul 3, 2019 · 3 comments
Closed

Don't flag very close points on different layers/levels #6612

quincylvania opened this issue Jul 3, 2019 · 3 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@quincylvania
Copy link
Collaborator

It's valid for features to be in exactly the same location if they vary on the z-axis.

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Jul 3, 2019
@1ec5
Copy link
Collaborator

1ec5 commented Jul 4, 2019

Tags to consider in this heuristic: ele, layer, level. Maybe also height for mounted features such as antennae, sirens, and flags, since it’s easier to ascertain than the absolute elevation? repeat_on is interesting but maybe nonessential for this issue.

@quincylvania
Copy link
Collaborator Author

@1ec5 I hesitate to use elevation only because I've seen overlapping points from different imports with slightly different ele values, though that's probably not very common.

@1ec5
Copy link
Collaborator

1ec5 commented Jul 4, 2019

Oh that’s a good point. I’ve seen that happen with coincident POIs imported from GNIS. Come to think of it, it wouldn’t be unreasonable to expect mappers to use layer to explicitly avoid this warning, since that’s what avoids crossing ways warnings for bridges and buildings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

2 participants