Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iD suggests "upgrading" tags on demolished roads #6775

Closed
tas50 opened this issue Aug 19, 2019 · 3 comments
Closed

iD suggests "upgrading" tags on demolished roads #6775

tas50 opened this issue Aug 19, 2019 · 3 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@tas50
Copy link

tas50 commented Aug 19, 2019

If a road has the service tag and a demolished tag, but not the highway tag iD will suggest you upgrade the road with to add the service tag. I missed this one while upgrading some other tags and unleashed an angry local mapper. iD should probably just ignore tag upgrades when the demolished tag is on the node.

Screen Shot 2019-08-19 at 10 45 11 AM

Screen Shot 2019-08-19 at 10 45 18 AM

@bhousel
Copy link
Member

bhousel commented Aug 19, 2019

I don't think iD should match the preset for service=driveway without highway=service
https://github.com/openstreetmap/iD/blob/master/data/presets/presets/highway/service/driveway.json

It looks like this was changed in 94096be
(cc @quincylvania)

@quincylvania
Copy link
Collaborator

I don't think iD should match the preset for service=driveway without highway=service

Yeah that's fine. I hadn't considered OSM's lifecycle tagging system at the time.

@quincylvania quincylvania added this to the 2.15.5 milestone Aug 19, 2019
@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Aug 19, 2019
@quincylvania quincylvania self-assigned this Aug 19, 2019
@bhousel
Copy link
Member

bhousel commented Aug 19, 2019

Thanks for the quick fix! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants