Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power=transformer should only be used on nodes #6779

Closed
flacombe opened this issue Aug 20, 2019 · 9 comments
Closed

power=transformer should only be used on nodes #6779

flacombe opened this issue Aug 20, 2019 · 9 comments
Assignees
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@flacombe
Copy link

Hi

Currently, iD doesn't warn about the usage of power=transformer on polygons or relations.
Mappers can easily confuse the device (the transformer) and the site (the substation) which houses the first.

As transformers are devices, they should get their own node and not be confused with buildings or surrounding fences instead of substations.
power=transformer is incompatible with building=*, ways and areas.

Is this possible to warn users when power=transformer is encountered on any other object than a node please?
See wiki : https://wiki.openstreetmap.org/wiki/Tag:power%3Dtransformer

We currently have dozen of mistakes on Osmose item 9100/class 91001 and rising
http://osmose.openstreetmap.fr/fr/errors/?item=9100&class=91001
http://osmose.openstreetmap.fr/fr/errors/graph.png?item=9100&class=91001

All the best

@quincylvania
Copy link
Collaborator

@flacombe I don't know why iD allowed power=transformer on areas before, but it looks like JOSM doesn't so I'm comfortable switching despite the nearly 15,000 ways with this tag. It's really nice to limit features to fewer geometries.

Is this possible to warn users when power=transformer is encountered on any other object than a node please?

iD should do this automatically once we do #6319.

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Aug 20, 2019
@quincylvania quincylvania self-assigned this Aug 20, 2019
@quincylvania quincylvania added this to the 2.15.5 milestone Aug 20, 2019
@bhousel
Copy link
Member

bhousel commented Aug 20, 2019

@flacombe I don't know why iD allowed power=transformer on areas before

Looks like the wiki was changed back in 2013: https://wiki.openstreetmap.org/w/index.php?title=Tag%3Apower%3Dtransformer&type=revision&diff=952869&oldid=932395

My best guess is iD probably just was following the old recommendation from before.

@flacombe
Copy link
Author

flacombe commented Aug 20, 2019

What a quick fix, that's really nice guys, thank you :)

My best guess is iD probably just was following the old recommendation from before.

Indeed, tagging has became more precise after the substation refinement proposal (2013).
No offense with that, iD isn't responsible of increasing osmose error rate I mentioned at the start of the discussion. And it will surely help to reduce it in next weeks ;)

@flacombe
Copy link
Author

flacombe commented Mar 1, 2020

Hi guys,

There must have been an error in this update because in iD 2.17.2, I still don't get a warning when adding power=transformer to an area
What am I doing wrong?

@bhousel
Copy link
Member

bhousel commented Mar 1, 2020

There must have been an error in this update because in iD 2.17.2, I still don't get a warning when adding power=transformer to an area
What am I doing wrong?

2.17.2 is just 2.17.1 but with the Maxar layers restored.
Both our master and 2.x branches are un-deployable right now. 😓

@bhousel
Copy link
Member

bhousel commented Mar 1, 2020

Sorry, I misspoke, this was supposed to be in 2.15. I'll have to investigate what happened.

@bhousel bhousel reopened this Mar 1, 2020
@quincylvania
Copy link
Collaborator

I closed this issue because I removed the area geometry from the Transformer preset. There's no warning because iD doesn't yet warn about areas that are expected to be another type of geometry…

@flacombe
Copy link
Author

flacombe commented Mar 2, 2020

The point is not only about areas

Users should also get a warning when they mix a building and a transformer (see incompatibility in wiki).
Currently I can put them both on an area (or a node) without any warning.

That cause dozen of objects being mapping as such in France because common people use to call a minor distribution substation a "transformer". They see transformer in the list and use it without idea to look at wiki. Then the only thing to encourage them to discover power=substation is a warning in the editor.
Example (I'm @infosreseaux and @deuzeffe is a colleague of mine at OSM FR board) : https://twitter.com/R1Rail/status/1232622770883846147?s=20

@quincylvania
Copy link
Collaborator

Closing in favor of #8231, which is generalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants