Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnecting selected way should move the new node interactively #6904

Closed
1ec5 opened this issue Oct 1, 2019 · 2 comments
Closed

Disconnecting selected way should move the new node interactively #6904

1ec5 opened this issue Oct 1, 2019 · 2 comments
Labels
enhancement An enhancement to make an existing feature even better wontfix Not planning to work on this at this time

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Oct 1, 2019

When disconnecting a specific way from an intersection node, the newly created node should follow the mouse cursor, similar to the interactive Continue or Move tools.

Steps to reproduce:

  1. Select a way.
  2. Hold down Shift and select a node along that way that is shared among multiple ways.
  3. Click Disconnect.

Actual results: The node along the selected way is duplicated at the same location and the selected way is no longer connected to the other ways. Clicking on the intersection may select the existing node or the new node, seemingly nondeterministically.

Expected results: The node along the selected way is in move mode, following the cursor until the user clicks somewhere on the map. The selected way is no longer connected to the other ways. While in move mode, pressing the Esc key leaves the node at the original location.

The proposed behavior would give the user control over the node’s placement, avoiding the headache of selecting the new node from a pile of coincident nodes. Moreover, if the user accidentally disconnects the node, they get an obvious indication that something has happened. #2206 is similar but for the case where all the ways at a given node are disconnected from each other, without first selecting a particular way.

@1ec5 1ec5 added the enhancement An enhancement to make an existing feature even better label Oct 1, 2019
@quincylvania
Copy link
Collaborator

So lately I've been doing a lot of work to build touch/stylus support for iD that works as seamlessly as possible with the traditional mouse and keyboard workflows. Unfortunately, the existing move mode doesn't really work for touch input since touches can't move around the map while "up". Thus, two-step operations like the one described are unmanageable and I've actually been thinking about ways to replace them (see #6674 and #7599). While we could theoretically enable this workflow for mouse/keyboard input only, I'd personally prefer to avoid the fragmentation and just fix the general case of disconnected node selection via #2206.

@quincylvania quincylvania added the considering Not Actionable - still considering if this is something we want label May 28, 2020
@quincylvania
Copy link
Collaborator

Regrettably, I still don't see a great way to do this with parity on touchscreens.

#7984 was just opened about making the nodes of the selected way the draggable ones (which I'm sure has been mentioned before but I don't see a matching issue). This should make the scenario a lot more predictable.

@quincylvania quincylvania added wontfix Not planning to work on this at this time and removed considering Not Actionable - still considering if this is something we want labels Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better wontfix Not planning to work on this at this time
Projects
None yet
Development

No branches or pull requests

2 participants