Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add tag swimming_pool=... on swimming pool #7100

Closed
alphensebezorger opened this issue Dec 8, 2019 · 2 comments
Closed

Don't add tag swimming_pool=... on swimming pool #7100

alphensebezorger opened this issue Dec 8, 2019 · 2 comments

Comments

@alphensebezorger
Copy link

Currently the editor offers a field "Type" when editing a swimming pool, which results in a tag swimming_pool=.... According to the wiki, this key is only used indicate the presence of a swimming pool in another facility (swimming_pool=yes), not on objects tagged leisure=swimming_pool. I feel adding this key should be avoided, possibly by removing the "Type" field alltogether.

@1ec5
Copy link
Collaborator

1ec5 commented Dec 9, 2019

Thanks for pointing out this ambiguity. If I’m reading osm tag history correctly, some swimming_pool values like outdoor were in use before #5301 added a field for it, though not abundantly. Is there another key in use that indicates the kind of swimming pool?

I added swimming_pool to the index of homonymous keys for awareness.

@bhousel bhousel added the waitfor-consensus Waiting for OpenStreetMap consensus label Dec 9, 2019
@bhousel
Copy link
Member

bhousel commented Jan 27, 2020

yes I remember that when we did #5301 the tag was already being used this way..

@bhousel bhousel closed this as completed Jan 27, 2020
@bhousel bhousel removed the waitfor-consensus Waiting for OpenStreetMap consensus label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants