Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the presets folder into an own repository #7702

Closed
PhilippRigoll opened this issue Jun 13, 2020 · 3 comments · Fixed by #8175
Closed

Move the presets folder into an own repository #7702

PhilippRigoll opened this issue Jun 13, 2020 · 3 comments · Fixed by #8175
Assignees
Labels
chore-dependency Improvements to one of iD's dependencies preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@PhilippRigoll
Copy link

I propose to move the presets folder into an own repositiory and include it here using git submodules. This way presets are separated from the rest of the codebase. I think the code and the presets should be unrelated. This also enables other editors to easily use these presets via git submodules.

@manfredbrandl
Copy link
Contributor

Also Quality Assurance Tools could use the repository and automatically find inconsistencies between the presets and other resources (wiki, new trending tags, etc).

@kymckay
Copy link
Collaborator

kymckay commented Jun 14, 2020

Some history of this:

#2656
#6483
#7130

@quincylvania quincylvania added chore-dependency Improvements to one of iD's dependencies preset An issue with an OpenStreetMap preset or tag labels Oct 21, 2020
@quincylvania quincylvania self-assigned this Nov 3, 2020
@quincylvania quincylvania added this to the Next Major Release milestone Nov 3, 2020
@quincylvania
Copy link
Collaborator

I'd say it's high time to do this. Beyond the technical advantages to modularity, it'd be a huge benefit organizationally if tagging issues could live in a separate repository from the rest of iD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-dependency Improvements to one of iD's dependencies preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants