Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"manual imagery" descriptions not translatable #7724

Open
manfredbrandl opened this issue Jun 22, 2020 · 9 comments
Open

"manual imagery" descriptions not translatable #7724

manfredbrandl opened this issue Jun 22, 2020 · 9 comments
Labels
bug A bug - let's fix this! localization Adapting iD across languages, regions, and cultures

Comments

@manfredbrandl
Copy link
Contributor

image
image

@maro-21
Copy link

maro-21 commented Jun 23, 2020

I reported it four months ago in #7358 and it was closed as solved.

@manfredbrandl
Copy link
Contributor Author

manfredbrandl commented Jun 23, 2020

The strings All fields, All tags and All relations are translatable now, so #7358 is solved, but not for the maxar strings. I hope "Somebody" will help here.

@quincylvania quincylvania added the localization Adapting iD across languages, regions, and cultures label Jun 23, 2020
@quincylvania
Copy link
Collaborator

quincylvania commented Jun 23, 2020

Turns out the Maxar strings have a different underlying issue from the other strings in #7358. Since they use encrypted endpoints, they're not included in the editor-layer-index and so don't use the standard imagery translation workflow.

@quincylvania quincylvania self-assigned this Jun 24, 2020
@quincylvania quincylvania added this to the 2.18.0 milestone Jun 24, 2020
@quincylvania quincylvania reopened this Jun 24, 2020
@manfredbrandl
Copy link
Contributor Author

@quincylvania no maxar strings in transifex as you have probably seen and reopened

@quincylvania
Copy link
Collaborator

quincylvania commented Jun 24, 2020

no maxar strings in transifex as you have probably seen and reopened

@manfredbrandl Yep. I mistakenly thought Transifex pulled the strings from en.json, but it actually pulls the imagery and community strings right from their respective projects. This is okay, but it means we'll probably have to include the Maxar strings in core instead of imagery.

Screen Shot 2020-06-24 at 11 50 18 AM

@manfredbrandl
Copy link
Contributor Author

Including maxar string in core not imagery: not the best but the best available solution so far. very okay for me.

@maro-21
Copy link

maro-21 commented Jun 24, 2020

  • There should be a space between 50 and cm
  • Why are there two Maxar layers if they have the same imagery?
  • Why are there two Esri layers if they have the same imagery?

@quincylvania
Copy link
Collaborator

Why are there two Maxar layers if they have the same imagery?
Why are there two Esri layers if they have the same imagery?

@maro-21 They're not the same imagery all over the globe. Both companies maintain two separate endpoints and can independently update the data for any given location at any time.

@quincylvania quincylvania removed this from the 2.18.0 milestone Jun 26, 2020
@quincylvania quincylvania removed their assignment Jan 26, 2023
@tyrasd tyrasd changed the title Maxar imagery explanation not translatable "manual imagery" descriptions not translatable Jul 7, 2023
@tyrasd
Copy link
Member

tyrasd commented Jul 7, 2023

Currently, the Maxar imagery is unavailable for mapping (see #9710), but the issue applies in principle to all sources in data/manual_imagery.json. Currently, these are the two Mapbox layers: Mapbox Satellite and the Locator Overview overlay) Affected are only sources which are not also present in ELI1, so currently, no layers are affected by this bug, so a workaround to avoid this issue would be to always add iD's manual imagery also to ELI (excluding any potentially iD specific details like API keys, etc.).

Footnotes

  1. The iD project on Transifex is configured to pull the to-be-translated strings for the "imagery" resource directly from the ELI repository. Because of that, iD's build scripts cannot simply "add" the manual imagery to the translation source files.

@tyrasd tyrasd added the bug A bug - let's fix this! label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

4 participants