Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop The Noun Project integration #8030

Closed
quincylvania opened this issue Sep 28, 2020 · 0 comments
Closed

Drop The Noun Project integration #8030

quincylvania opened this issue Sep 28, 2020 · 0 comments
Assignees
Labels
chore-dependency Improvements to one of iD's dependencies icon An issue involving icons
Milestone

Comments

@quincylvania
Copy link
Collaborator

In #5691 we added support for pulling icons from https://thenounproject.com. However, for #7959 we have to replace the request package for downloading icons, which is tricky since TNP requires oauth. To date we only use seven icons, likely since there are a number of drawbacks:

  • An account with API tokens is required for downloading icons with iD's build scripts.
  • Most icons are not public domain and there's no way to search/filter by license.
  • Most icons don't match iD's style requirements.
  • The identifiers are numeric and thus aren't descriptive.

I don't think it's worth maintaining this integration for seven icons. We can just add any of the public domain icons to Temaki in order to use them with iD. This also lets us edit the icons as needed, give them descriptive names, and provide them to other projects that use Temaki.

@quincylvania quincylvania added chore-dependency Improvements to one of iD's dependencies icon An issue involving icons labels Sep 28, 2020
@quincylvania quincylvania self-assigned this Sep 28, 2020
@quincylvania quincylvania added this to the 2.19.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-dependency Improvements to one of iD's dependencies icon An issue involving icons
Projects
None yet
Development

No branches or pull requests

1 participant