Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity missing units for water tank #8078

Closed
jidanni opened this issue Oct 13, 2020 · 11 comments
Closed

Capacity missing units for water tank #8078

jidanni opened this issue Oct 13, 2020 · 11 comments
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@jidanni
Copy link
Contributor

jidanni commented Oct 13, 2020

Here (for water tank), we see "Height (meters)" but Capacity units is left for a research mission.
X5
OK, I found it: capacity in cubic metres...
Consider putting that on the panel like already done for Height. Thanks.

@maro-21
Copy link

maro-21 commented Oct 13, 2020

"Capacity" string should be split into multiple strings because the same label is used for example on amenity=restaurant - in my language it's not the same word ("objętość" for storage_tank and "liczba miejsc" for restaurant).

@karmanya007
Copy link
Contributor

@jidanni Do i have to change the label in presets.yaml file or fields.json or in capacity.json file??

@quincylvania
Copy link
Collaborator

@karmanya007 Change the label in capacity.json and then run npm run build and commit the derived data as well.

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Oct 21, 2020
@karmanya007
Copy link
Contributor

@quincylvania Thanks 😄

@quincylvania
Copy link
Collaborator

@karmanya007 Actually, for this you'll have to create a new field like capacity_volume.json and leave the existing capacity field alone, since it's used for other things too. Check out the presets guide.

@karmanya007
Copy link
Contributor

@quincylvania Okay. One more thing. Do i have to switch to the dev server on the localhost version?

@quincylvania
Copy link
Collaborator

@karmanya007 You only have to use the dev server if you need to upload fake data, so probably not for this issue. If you're unsure about something, feel free to open a draft pull request and we can discuss things there.

@karmanya007
Copy link
Contributor

@quincylvania I have add the units to both the water tank and the storage tank (They both use the same key=capacity). Is this fine or only the water tank needs the units (cubic meter)?

@karmanya007
Copy link
Contributor

karmanya007 commented Oct 22, 2020

@quincylvania PR Opened

@karmanya007
Copy link
Contributor

@quincylvania Could you review #8112

@quincylvania
Copy link
Collaborator

Done by @karmanya007 in #8112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

4 participants