Capacity missing units for water tank

[jidanni]

Here (for water tank), we see "Height (meters)" but Capacity units is left for a research mission.

OK, I found it: capacity in cubic metres...
Consider putting that on the panel like already done for Height. Thanks.

[maro-21]

"Capacity" string should be split into multiple strings because the same label is used for example on amenity=restaurant - in my language it's not the same word ("objętość" for storage_tank and "liczba miejsc" for restaurant).

[karmanya007]

@jidanni Do i have to change the label in presets.yaml file or fields.json or in capacity.json file??

[quincylvania]

@karmanya007 Change the label in capacity.json and then run npm run build and commit the derived data as well.

[karmanya007]

@quincylvania Thanks 😄

[quincylvania]

@karmanya007 Actually, for this you'll have to create a new field like capacity_volume.json and leave the existing capacity field alone, since it's used for other things too. Check out the presets guide.

[karmanya007]

@quincylvania Okay. One more thing. Do i have to switch to the dev server on the localhost version?

[quincylvania]

@karmanya007 You only have to use the dev server if you need to upload fake data, so probably not for this issue. If you're unsure about something, feel free to open a draft pull request and we can discuss things there.

[karmanya007]

@quincylvania I have add the units to both the water tank and the storage tank (They both use the same key=capacity). Is this fine or only the water tank needs the units (cubic meter)?

[karmanya007]

@quincylvania PR Opened

[karmanya007]

@quincylvania Could you review #8112

[quincylvania]

Done by @karmanya007 in #8112.