Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Backgrounds list by category #8814

Open
jidanni opened this issue Nov 18, 2021 · 12 comments · May be fixed by #8826
Open

Organize Backgrounds list by category #8814

jidanni opened this issue Nov 18, 2021 · 12 comments · May be fixed by #8826
Labels
enhancement An enhancement to make an existing feature even better usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Nov 18, 2021

Description

Currently we see:

Backgrounds

  • Bing aerial imagery
  • CyclOSM
  • Esri World Imagery
  • Esri World Imagery (Clarity) Beta
  • Mapbox Satellite
  • Maxar Premium Imagery
  • OpenStreetMap (Standard)
  • OpenTopoMap
  • Stamen Terrain
  • NLSC General Map with Contour line
  • Taiwan Land-Section Data
  • Taiwan Village Boundaries
  • Taiwan e-Map Open Data
  • None
  • Custom

Better would be:

Backgrounds

  • Bing aerial imagery
  • Esri World Imagery
  • Esri World Imagery (Clarity) Beta
  • Mapbox Satellite
  • Maxar Premium Imagery

  • CyclOSM
  • OpenStreetMap (Standard)
  • OpenTopoMap
  • Stamen Terrain

  • NLSC General Map with Contour line
  • Taiwan Land-Section Data
  • Taiwan Village Boundaries
  • Taiwan e-Map Open Data

  • None
  • Custom
@1ec5
Copy link
Collaborator

1ec5 commented Nov 18, 2021

The suggested organization would require osmlab/editor-layer-index#136.

@1ec5 1ec5 added the waitfor-upstream Waiting for something in an upstream project label Nov 18, 2021
@jidanni
Copy link
Contributor Author

jidanni commented Nov 18, 2021

For now please move CyclOSM down to my suggested position.

@1ec5
Copy link
Collaborator

1ec5 commented Nov 18, 2021

iD doesn’t special-case specific layers to put them in specific locations, other than None and Custom (which are built-in options rather than layers loaded from ELI).

@jidanni
Copy link
Contributor Author

jidanni commented Nov 18, 2021

Looking at where the alphabet breaks order, I detect three groups above.
Hmm, so apparently CyclOSM needs to be renamed O-CyclOSM through Z-CyclOSM,
as a hack, to get it to group properly with the non-image layers!

@1ec5
Copy link
Collaborator

1ec5 commented Nov 18, 2021

Oh huh, I never noticed that it does the same in the U.S. with “National Agricultural Imagery Program” appearing between “Stamen Terrain” and “U.S. Forest Service roads”. Looks like it’s actually sorted first in descending order by coverage area, then in ascending order by name:

.sort(function(a, b) {
return a.best() && !b.best() ? -1
: b.best() && !a.best() ? 1
: d3_descending(a.area(), b.area()) || d3_ascending(a.name(), b.name()) || 0;
});

It’s a bit unfortunate that the first sort is in descending order, because it shifts the local sources down to where users are less likely to notice them. I guess the expectation is that good local sources are already marked as best in ELI, but that’s a tricky decision because “best” can mean many things: osmlab/editor-layer-index#130.

@jidanni
Copy link
Contributor Author

jidanni commented Nov 18, 2021

Also

  • OpenStreetMap (Standard)
    Data guaranteed to already be in iD.
  • OpenTopoMap
    same, except for contour related...

So maybe they should be real low in the list.

@todrobbins
Copy link

I like the idea of grouping the available layers in types (map renderings, remote sensing/imagery), and maybe even allow for the list to be rearranged by drag+drop to your preference. 🤷🏻‍♂️

@jidanni
Copy link
Contributor Author

jidanni commented Nov 19, 2021 via email

@tyrasd
Copy link
Member

tyrasd commented Nov 19, 2021

I think as a start, we could at least sort by the imagery's ELI category which would be osmbasedmap for cyclosm for example.

@tyrasd tyrasd added enhancement An enhancement to make an existing feature even better usability An issue with ease-of-use or design labels Nov 19, 2021
@1ec5
Copy link
Collaborator

1ec5 commented Nov 20, 2021

Cool, I hadn’t realized osmlab/editor-layer-index#733 introduced a category system. I guess osmlab/editor-layer-index#136 is just tracking a follow-on discussion about a specific categorization issue.

@1ec5 1ec5 changed the title Organize Backgrounds list Organize Backgrounds list by category Nov 20, 2021
@tyrasd tyrasd linked a pull request Nov 23, 2021 that will close this issue
4 tasks
@tyrasd tyrasd removed the waitfor-upstream Waiting for something in an upstream project label Nov 23, 2021
@boothym
Copy link
Contributor

boothym commented Dec 2, 2021

Just to say that I agree with this - I've misclicked on CyclOSM a number of times since it was moved to 2nd in the list!

I made a similar suggestion years ago when the layers more than 20 years old were removed from iD, of having a dropdown where for example historic layers could be hidden rather than removed altogether.

#3453 (comment)

@endolith
Copy link

endolith commented Nov 7, 2022

Yes, please put all the satellite maps together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better usability An issue with ease-of-use or design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants