Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Use Shift click first to select just one line." #8818

Closed
jidanni opened this issue Nov 18, 2021 · 7 comments
Closed

Add "Use Shift click first to select just one line." #8818

jidanni opened this issue Nov 18, 2021 · 7 comments
Labels
considering Not Actionable - still considering if this is something we want documentation Improvements to the iD documentation operation An editing operation / edit menu item

Comments

@jidanni
Copy link
Contributor

jidanni commented Nov 18, 2021

Description

Here "Divide these lines at this point" needs added "(Use Shift+click instead to just work on the current line.)" Else the user needs to read #7992.

Screenshots

20211119T032358

@tyrasd tyrasd added documentation Improvements to the iD documentation operation An editing operation / edit menu item labels Nov 23, 2021
@tyrasd
Copy link
Member

tyrasd commented Nov 23, 2021

the user needs to read #7992

(Slightly joking:) It would be sufficient to read the built-in help:

😉

On topic, after actually reading #7992, I still don't get what the big deal is about users accidentally splitting a way on one additional intersection point. Generally speaking, shorter lines are easier to handle when mapping than long ones (e.g. in terms of a reduced potential of upload conflicts and easier precise mapping of properties such as road surfaces, number of lanes, etc.). Also for relations such as multipolygons or routes it does not make a difference if the consisting ways are split.

That said, I guess it would also not hurt to put a small hint in the tooltip. The benefit would be that users could find out about the other functionality of the split operation via that. I'll think about it.

@tyrasd tyrasd added the considering Not Actionable - still considering if this is something we want label Nov 23, 2021
@jidanni
Copy link
Contributor Author

jidanni commented Nov 24, 2021

Actually more buttons should appear in such cases:

  • One button for splitting the current line.
  • One button for splitting all lines.

@jidanni
Copy link
Contributor Author

jidanni commented Nov 24, 2021

(I am usually splitting the case where the two four roads have three names, not two as assumed by the previous mapper.)

@boothym
Copy link
Contributor

boothym commented Nov 27, 2021

Funnily enough I came here to post about the same issue. With the image below I wanted to split the service road and delete it between the other two roads - so I clicked on it, then selected the point and pressed X. However that split the tertiary road as well. At least I now know to select the road + point using shift before splitting! 😃
idsplit

On topic, after actually reading #7992, I still don't get what the big deal is about users accidentally splitting a way on one additional intersection point. Generally speaking, shorter lines are easier to handle when mapping than long ones (e.g. in terms of a reduced potential of upload conflicts and easier precise mapping of properties such as road surfaces, number of lanes, etc.).

Sure, but if I need to have more precise mapping then I will split it intentionally. In the example above, after the tertiary road has been split then I would need to rejoin or select both sections if I wanted to add a surface tag to it. Suppose it is just unexpected and perhaps unnecessary behaviour from the editor 😉

@jidanni
Copy link
Contributor Author

jidanni commented Nov 27, 2021

I still don't get what the big deal is about users accidentally splitting a way on one additional intersection point. Generally speaking, shorter lines are easier to handle when mapping than long ones...

Well if the government changes Norfsberg Lane to Nerfsburg Lane, and somebody has for no reason split it into five lines, then we must edit five slices instead of one.

easier precise mapping of properties such as road surfaces, number of lanes, etc.).

Well we usually know and map the name of a road, and only if we later have spare time, go and visit it to find out what kind of pavement it is.

@1ec5
Copy link
Collaborator

1ec5 commented Nov 28, 2021

The Shift-modified context menu items feel more natural on macOS, where dynamic menu items are pervasive. But this convention is less familiar to users on Windows and Linux, where menu items are typically shown regardless of modifier keys and only Office hides lesser-used items. Dynamic menu items are great for reducing clutter and making the most common operations convenient to access, but there is a tradeoff in discoverability. Adding a hint to the tooltip is a great idea; users would be much more likely to read that than the full help documentation.

@tyrasd tyrasd closed this as completed in d062c1b Nov 30, 2021
@tyrasd
Copy link
Member

tyrasd commented Nov 30, 2021

this is how this looks now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want documentation Improvements to the iD documentation operation An editing operation / edit menu item
Projects
None yet
Development

No branches or pull requests

4 participants