Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website link in editor links to openstreetmap.org when http/https prefix missing #8827

Closed
andrewpmk opened this issue Nov 27, 2021 · 2 comments
Labels
field An issue with a field in the user interface

Comments

@andrewpmk
Copy link

URL

No response

How to reproduce the issue?

Website link redirects to openstreetmap.org when http:// or https:// is missing.

To reproduce:

  • Enter a website link in the website field of editor with the http:// or https:// prefix missing
  • Click the "visit website" link to the right of the website (the arrow pointing up and to the right)
  • For example, I was editing a funeral home and entered website www.turnerporter.ca
  • Click on link, redirects me to https://www.openstreetmap.org/www.turnerporter.ca
  • Should either redirect to https://turnerporter.ca/, or display a warning/error that the http:// or https:// prefix is missing and suggest that you add the prefix

Screenshot(s) or anything else?

image
image

Which iD Editor versions do you see the issue on?

Released version at openstreetmap.org/edit

Which browsers are you seeing this problem on?

Firefox

@1ec5
Copy link
Collaborator

1ec5 commented Nov 28, 2021

I think the field was set to type="url" at one point, so that the browser would highlight a malformed URL, as seen in #5658 (comment). These days, it’s just a type="text". I wonder if that changed as part of factoring out id-tagging-schema as a separate repository (#8175 etc.).

@tyrasd tyrasd closed this as completed in 7015fae Nov 30, 2021
@tyrasd
Copy link
Member

tyrasd commented Nov 30, 2021

Btw: there used to be a validator for this, but it was removed in #6831

@tyrasd tyrasd added the field An issue with a field in the user interface label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface
Projects
None yet
Development

No branches or pull requests

3 participants