Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex for gnis:feature_id allows leading zeros #1017

Closed
watmildon opened this issue Sep 26, 2023 · 2 comments
Closed

Regex for gnis:feature_id allows leading zeros #1017

watmildon opened this issue Sep 26, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@watmildon
Copy link
Contributor

Describe the bug
The regex for the field gnis:feature_id allows leading zeros. Previous imports have incidentally had IDs with leading zeros but that has now been corrected.

To Reproduce
Steps to reproduce the behavior:

  1. Create an object with gnis:feature_id=00000123

Expected behavior
Warning as this is not proper for a numerical id field.

Additional context
I have supplied this suggested PR #1007
@watmildon watmildon added the bug Something isn't working label Sep 26, 2023
@qugebert
Copy link
Contributor

Isn't this closed by #1007 ?

@watmildon
Copy link
Contributor Author

It is! Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qugebert @watmildon