Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding amenity=funeral_hall from search menu removes building=funeral_hall #1313

Closed
Oivo35 opened this issue Aug 17, 2024 · 2 comments · Fixed by #1324
Closed

Adding amenity=funeral_hall from search menu removes building=funeral_hall #1313

Oivo35 opened this issue Aug 17, 2024 · 2 comments · Fixed by #1324
Labels
bug Something isn't working waitfor-pr-merge There is a PR for this issue which is waiting for review/merge

Comments

@Oivo35
Copy link

Oivo35 commented Aug 17, 2024

Adding amenity=funeral_hall from search menu removes tag building=funeral_hall.

  1. original tag
    1
  2. choosing amenity=funeral_hall from menu
    2
  3. tags after adding amenity=funeral_hall
    3
@Oivo35 Oivo35 added the bug Something isn't working label Aug 17, 2024
@arch0345 arch0345 mentioned this issue Aug 25, 2024
Merged
@tordans
Copy link
Collaborator

tordans commented Sep 1, 2024

@Oivo35 could you please review #1324 (comment) if that fixes the issue and add some test cases to that PR? That would help a lot.

@tordans tordans added the waitfor-pr-merge There is a PR for this issue which is waiting for review/merge label Sep 1, 2024
@Oivo35
Copy link
Author

Oivo35 commented Sep 1, 2024

@tordans Thanks, now it seems fixed,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working waitfor-pr-merge There is a PR for this issue which is waiting for review/merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add building_area_yes field to Funeral Service Hall preset arch0345/id-tagging-schema
2 participants
@tordans @Oivo35