Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle tagging on the aeroway key is incorrectly flagged by validator #920

Closed
nc011 opened this issue Jun 13, 2023 · 1 comment
Closed
Labels
bug Something isn't working duplicate This issue or pull request already exists upstream-iD An issue that is concerning the main iD repo

Comments

@nc011
Copy link

nc011 commented Jun 13, 2023

Describe the bug
Using lifecycle tagging on the aeroway key (e.g. disused:aeroway=* and abandoned:aeroway=*) is incorrectly flagged by the validator for the runway and taxiway values when (correctly) used on ways.

  • Area should be closed area based on the tag "disused:aeroway=runway"

The validator is OK with aeroway=runway or aeroway=taxiway as a way. It's just an issue when adding the lifecycle prefix.

To Reproduce
Steps to reproduce the behavior:

  1. Draw a line
  2. Tag as aeroway=runway behaviour is as expected
  3. Change to disused:aeroway=runway to map a disused runway

Expected behavior
No validator warning should be issued.

Additional context
Other values in this lifecycle and tag scheme (e.g. apron and aerodrome) should be mapped as areas and so should have a validator warning when mapped as a way.

@nc011 nc011 added the bug Something isn't working label Jun 13, 2023
@arch0345
Copy link
Contributor

Duplicate of openstreetmap/iD#9491

This has been fixed in openstreetmap/iD#9483, however this won't be available on osm.org until the next release of iD. You can test to see if this fix works on the prelease version.

@tyrasd tyrasd closed this as completed Jul 4, 2023
@tyrasd tyrasd added upstream-iD An issue that is concerning the main iD repo duplicate This issue or pull request already exists labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists upstream-iD An issue that is concerning the main iD repo
Projects
None yet
Development

No branches or pull requests

3 participants