Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Features button looks like a help button #1712

Closed
1ec5 opened this issue Jan 3, 2018 · 9 comments
Closed

Query Features button looks like a help button #1712

1ec5 opened this issue Jan 3, 2018 · 9 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 3, 2018

The Query Features button is labeled with a question mark, which makes it look like a help button:

query

Since iD places its help button in roughly the same spot, iD uses a bookmark-in-book icon, which is difficult to discern. openstreetmap/iD#4650 would turn it into a question mark.

The query button’s function reminds me of click-to-select functions found in various developer tools, such as the Inspect Element function in browser DOM inspectors. In Firefox and Chrome, the button’s icon depicts an arrow cursor pointing at a box, while Safari uses a crosshair icon:

firefox chrome safari
Inspect buttons in Firefox, Chrome, and Safari

In this context, I think the crosshair could be confused with geolocation, but the pointer arrow should be pretty self-explanatory. Unlike the existing geolocation button, this arrow would more closely resemble a mouse cursor (pointing to the northwest and having a shaft).

/cc @bhousel

@tomhughes
Copy link
Member

Happy to accept a PR with a better icon.

@manfredbrandl
Copy link

manfredbrandl commented Jan 3, 2018

I suggest, that the icon should look like the cursor after klicking the query feature:
image

@tomhughes
Copy link
Member

Well that isn't how my cursor looks... The cursor shape is browser specific.

@tomhughes
Copy link
Member

To explain more the cursor is styled as cursor: help which is a builtin cursor and despite https://developer.mozilla.org/en-US/docs/Web/CSS/cursor showing an example much like your one what Firefox actually renders is a simple question mark with an arrow at the base.

@manfredbrandl
Copy link

All my browsers (IE 11.0.9600.18837, Firefox 53.0.7, Chrome 63.0.3239.84) show the same icon.
@tomhughes What do you think of my suggested icon-shape, even if the cursor may look different on some browsers?

@tomhughes
Copy link
Member

Well firefox on linux has always done what I described for me but I don't seem to be able to capture a picture of it!

Looks fine as an icon to me anyway.

@manfredbrandl
Copy link

Capturing the cursor seems to be difficult. On Windows the utility psr.exe which is usually used to produce an bug report including screen-video-capture helped. Isn't there also a screen-video-capture utility including cursor in Linux?

@tomhughes
Copy link
Member

Apparently it comes from the gnome theme:

question_arrow_000

@bhousel
Copy link
Member

bhousel commented Jan 3, 2018

I’ll just redraw the icon from scratch. This is what I do for most of the iD graphics. It’s easier than trying to capture/extract the cursor image, and anyway then the license of the produced icon is clear.

@bhousel bhousel mentioned this issue Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants