Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] internal style, font size #1686

Closed
atomGit opened this issue Nov 2, 2023 · 11 comments
Closed

[Bug] internal style, font size #1686

atomGit opened this issue Nov 2, 2023 · 11 comments

Comments

@atomGit
Copy link

atomGit commented Nov 2, 2023

Bug Report

Bug Description

if the browser font size is set to a large value, it creates display issues

Screenshots

example

settings dialog appears to be cut off at bottom

System Information

firefox 119
stylus 1.5.37
linux

@atomGit
Copy link
Author

atomGit commented Nov 2, 2023

in 'Language and Appearance' > 'Fonts', click the 'Advanced' button, then for the Latin font, set all 3 size prefs to something like 20+

sorry, i didn't realize setting the minimum font size was necessary

@tophf
Copy link
Member

tophf commented Nov 2, 2023

Indeed, Stylus never supported changing just the font size. Fixing this problem won't be easy though, so no promises...

@atomGit
Copy link
Author

atomGit commented Nov 2, 2023

it seems like a css problem - this fixes the first issue when i change...

.filter-selection select {
  height: 18px;

to...

.filter-selection select {
  height: unset;

the #help-popup looks a bit harder - i'm not understanding the hierarchy of the css, but if i get rid of these...

#help-popup {
  --pad-x: unset;
  --pad-y: unset;
  --pad-y2: unset;

...and set top to 0, i can see the whole window, but obviously that's not a proper fix - for whatever reason i can't get the content of the dialog window to scroll even though each #help-popup .contents has overflow-y: auto;

@atomGit
Copy link
Author

atomGit commented Nov 2, 2023

AH HA! try this...

#help-popup {
  top: 0;
  height: 100%;
  overflow: auto;
}

@atomGit
Copy link
Author

atomGit commented Dec 25, 2024

this issue seems to be getting worse - sometimes a site for which i have created a style isn't listed (or visible) in the popup because the number of list items seems to be cut off, while other times it is listed

potentially related: #1838

ff 133.x
stylus 1.5.51

@tophf
Copy link
Member

tophf commented Dec 25, 2024

Sounds like a bug. I can't fix it though if I don't investigate it in devtools myself. See if you can find a method of reproducing it reliably so I can follow it here.

@tophf
Copy link
Member

tophf commented Dec 25, 2024

Also, try the latest test build, which includes 2994182 for better popup sizing.

@atomGit
Copy link
Author

atomGit commented Dec 25, 2024

correction - i was wrong - it isn't that list items are missing, it's that sometimes items in the the popup are scrollable and sometimes not, even though the number of items remains the same (this is with the 1.5.51 build)

no big deal

@tophf
Copy link
Member

tophf commented Dec 25, 2024

Yes, that's the bug that I was referring to above.

@atomGit
Copy link
Author

atomGit commented Dec 25, 2024

ah, ok - i think this can be closed then???

@atomGit atomGit closed this as completed Dec 25, 2024
@tophf
Copy link
Member

tophf commented Dec 25, 2024

I hoped you could verify it first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants