Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version error more recognizable #463

Open
stonecrusher opened this issue Aug 7, 2018 · 7 comments
Open

Make version error more recognizable #463

stonecrusher opened this issue Aug 7, 2018 · 7 comments

Comments

@stonecrusher
Copy link
Contributor

Updating a UserCSS.
The local version was newer than the online one, so it didn't update. You click the force update button and nothing happens. Took me a good five minutes to find out what was wrong and that there indeed was an error message, but hidden as a tooltip on the button. The tooltip won't show if your pointer rests at the button you just clicked.

screenshot 194

Why not throw an alert?

In addition, the error message is not translated.

Stylus 1.4.13
FF 61.0.1

@tophf
Copy link
Member

tophf commented Aug 7, 2018

There's no force update button in this scenario.
Not sure there should be.

The tooltip won't show if your pointer rests at the button you just clicked.

Isn't this the standard behavior?

Why not throw an alert?

Because it's too invasive?

In addition, the error message is not translated.

Yeah, some of the update states aren't translated. I'll expose these strings.

@stonecrusher
Copy link
Contributor Author

There's no force update button in this scenario.

Ah right, that one has another icon. It's just the "search for update" button.

Not sure there should be.

Maybe. IDK, that's another issue.

Isn't this the standard behavior?

Yes but this only shows that a tooltip is inappropriate for error messages. I only discovered it by chance.
You will try to click again instead of resting your pointer on the button in hope for a tooltip. I even checked the console.

Because it's too invasive?

It's not. Clicking something with no response is bad UX.
I mean it doesn't have to be an alert. A balloontip popping up on click also does the job. It may be dismissed by clicking just somewhere else. But something has to happen when you click.

Yeah, some of the update states aren't translated. I'll expose these strings.

Nice!

@the-j0k3r
Copy link

the-j0k3r commented Aug 7, 2018

+1 for improved user experience, clearly showing something so one isnt left wondering or have no action when interacting with, shouldn't equal being too invasive, it goes to how its implemented and is a good UX practice.

I agree this should be some sort of balloon tooltipped message to match the already existing ones for similar type messages for other updates.

This shouldn't be an error anyway, at best a notice and at worst a warning, an error conveys something more serious.

Speaking of messages that are hard to see, if a server is unreachable when an update is triggered, you also have little to no visual indication and its buried like this.

@eight04
Copy link
Collaborator

eight04 commented Oct 3, 2018

Maybe we can display a tooltip like what we do with a successful update?
image

@stonecrusher
Copy link
Contributor Author

Sure, that would do the job. Maybe give another background color to show the message being about something conflicting.

@eight04
Copy link
Collaborator

eight04 commented Feb 4, 2019

I guess we should wait for #636 before adding this?

@Mottie
Copy link
Member

Mottie commented Feb 4, 2019

Yeah, I added styled tooltips instead of depending on the title attribute.

@tophf tophf removed the planned label Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants