Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the left panel tab bar wil hide when set hideSlotTabBar #175

Closed
bytemain opened this issue Dec 22, 2021 · 2 comments · Fixed by #227
Closed

the left panel tab bar wil hide when set hideSlotTabBar #175

bytemain opened this issue Dec 22, 2021 · 2 comments · Fixed by #227
Assignees
@bytemain
Labels
🐞 bug Something isn't working

Comments

@bytemain
Copy link
Member

bytemain commented Dec 22, 2021 •
edited
Loading

hideSlotTabBar 这个选项是为了隐藏 bottom slot 的 tabbar 引入的，但是并没有考虑到侧边栏的 TabBar 也会走这个逻辑，需要加一些逻辑来决定哪一部分会被隐藏，哪一部分不会被隐藏。

可以通过配置想来解决，或者只针对 bottom slot 隐藏
@bytemain bytemain added the 🐞 bug Something isn't working label Dec 22, 2021
@bytemain bytemain self-assigned this Dec 22, 2021
@bytemain bytemain changed the title 开启 hideSlotTabBar 之后左侧边栏会被一起隐藏掉 the left panel tab bar wil hide when set hideSlotTabBar Dec 22, 2021
@bytemain bytemain mentioned this issue Dec 28, 2021
Merged
1 task
@bytemain
Copy link
Member Author

/pre-release

@github-actions github-actions bot changed the title the left panel tab bar wil hide when set hideSlotTabBar 🤖 OpenSumi PreRelease Wed Dec 29 2021 Dec 29, 2021
@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.13.5-next-1640746503.0 publish successful! You can install prerelease version via `npm install package@2.13.5-next-1640746503.0

@bytemain bytemain changed the title 🤖 OpenSumi PreRelease Wed Dec 29 2021 the left panel tab bar wil hide when set hideSlotTabBar Dec 29, 2021
@erha19 erha19 mentioned this issue Jan 17, 2022
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bytemain bytemain

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 只允许 bottom slot 隐藏 tab opensumi/core
1 participant
@bytemain