Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] custom file icon does not work #3824

Closed
stimw opened this issue Jul 3, 2024 · 3 comments
Closed

[Question] custom file icon does not work #3824

stimw opened this issue Jul 3, 2024 · 3 comments
Labels
💬 question Further information is requested 👾 wontfix

Comments

@stimw
Copy link

stimw commented Jul 3, 2024

描述你的问题(Describe you question here)

开发了一个vscode语言插件,需要为该语言的文件后缀配相应的自定义 icon,通过在插件的 package.json contribute 中配置 icon :

"contributes": {
    "languages": [
      {
        // other fields ...
        "icon": {
          "light": "./icon.svg",
          "dark": "./icon.svg"
        }
      }
    ],
}

在 vscode 中可以正常显示 icon,opensumi 中没有用。这块的 api 暂时没有实现吗?

@stimw stimw added the 💬 question Further information is requested label Jul 3, 2024
@Ricbet
Copy link
Member

Ricbet commented Aug 23, 2024

插件注册的 languages 贡献点是在这个 LanguagesContributionPoint 进行处理的
https://github.com/opensumi/core/blob/main/packages/extension/src/browser/vscode/contributes/language.ts#L22

可以在 contribute 函数里新增对 icon 图标注册的逻辑。

可以参考这里的代码
https://github.com/opensumi/core/blob/main/packages/extension/src/browser/vscode/contributes/icon.ts#L73

Copy link

stale bot commented Oct 28, 2024

此问题已被自动标记为已过时,如果没有进一步的活动,它将被关闭。谢谢您的贡献。
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 👾 wontfix label Oct 28, 2024
@stale stale bot closed this as completed Nov 5, 2024
@Aimee1608
Copy link

插件注册的 languages 贡献点是在这个 LanguagesContributionPoint 进行处理的 https://github.com/opensumi/core/blob/main/packages/extension/src/browser/vscode/contributes/language.ts#L22

可以在 contribute 函数里新增对 icon 图标注册的逻辑。

可以参考这里的代码 https://github.com/opensumi/core/blob/main/packages/extension/src/browser/vscode/contributes/icon.ts#L73

请问能具体说明一下 怎么调整适配吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 question Further information is requested 👾 wontfix
Projects
None yet
Development

No branches or pull requests

3 participants