Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty component fix #133

Merged
merged 3 commits into from
Oct 26, 2015
Merged

Empty component fix #133

merged 3 commits into from
Oct 26, 2015

Conversation

andyroyle
Copy link
Collaborator

  • Don't treat an empty component as an error
  • Always call the callback to avoid blocking the render loop

@andyroyle
Copy link
Collaborator Author

closes #118

matteofigus added a commit that referenced this pull request Oct 26, 2015
@matteofigus
Merge pull request #133 from opentable/empty-component-fix
884e559 
Empty component fix
@matteofigus matteofigus merged commit 884e559 into master Oct 26, 2015
@matteofigus matteofigus deleted the empty-component-fix branch October 26, 2015 15:16
@matteofigus
Copy link
Member

Published in 0.18.3

@andyroyle
Copy link
Collaborator Author

😄

@matteofigus
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyroyle @matteofigus