Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli crash when oc dev reads a broken package.json #143

Merged
merged 2 commits into from
Nov 11, 2015
Merged

Fix cli crash when oc dev reads a broken package.json #143

merged 2 commits into from
Nov 11, 2015

Conversation

andyroyle
Copy link
Collaborator

  • wrapped the readJsonSync call in a try-catch, log it and then continue loading the other components
  • moved getComponentsByDir out into a separate file
  • cli/domain/local.js now has a dependency on logger
  • added tests to cover

turned out a bit larger than I had intended

@andyroyle
Copy link
Collaborator Author

closes #142

matteofigus added a commit that referenced this pull request Nov 11, 2015
@matteofigus
Merge pull request #143 from opentable/fix-cli-bug
162e049 
Fix cli crash when `oc dev` reads a broken package.json
@matteofigus matteofigus merged commit 162e049 into master Nov 11, 2015
@matteofigus matteofigus deleted the fix-cli-bug branch November 11, 2015 17:04
@matteofigus
Copy link
Member

Thanks @andyroyle - can you publish new version in npm using the new CONTRIBUTING.md instructions?

@andyroyle
Copy link
Collaborator Author

will do

@andyroyle
Copy link
Collaborator Author

https://github.com/opentable/oc/releases/tag/v0.19.3 👍

@matteofigus matteofigus mentioned this pull request Nov 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyroyle @matteofigus